From 1318ba38bd80a51b5bfbc1744f3d1316a94cb000 Mon Sep 17 00:00:00 2001 From: Joshua Oosthuizen Date: Wed, 18 Nov 2026 15:02:21 +0200 Subject: [PATCH] docs: Accounts plan, handover and changelog after the install work and Playwright run Co-Authored-By: Claude Opus 5.5 --- CHANGELOG.md | 8 ++++++-- docs/ACCOUNTS-1.0-PLAN.md | 21 +++++++++++++++++---- docs/HANDOVER.md | 2 +- 3 files changed, 24 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3112033..f6340fc 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,8 +13,12 @@ Phase 3 (docs/ACCOUNTS-1.0-PLAN.md), partly built on `feat/accounts-1.0`. `churchChangedSchema`, `churchObjectSchema`. - **`packages/auth-client`** (new): the product side of signing in. **`packages/ui`**: first components. -- **Scripts:** `products/accounts.sh`; `accounts` in `SUPPORTED_PRODUCTS` (deploy updates it when a - church has it; install doesn't yet). +- **Scripts:** `products/accounts.sh`; `accounts` in `SUPPORTED_PRODUCTS`; `crosscode install + --products accounts` (one product per install) and `crosscode add `. + +### Agent (1.1.0) + +- Install jobs for Accounts, and `add-product` jobs (a product next to a church's others). ## events@2.4.0, contracts@1.4.0 - unreleased diff --git a/docs/ACCOUNTS-1.0-PLAN.md b/docs/ACCOUNTS-1.0-PLAN.md index 2429b6a..4b9a02a 100644 --- a/docs/ACCOUNTS-1.0-PLAN.md +++ b/docs/ACCOUNTS-1.0-PLAN.md @@ -1,10 +1,10 @@ # Accounts 1.0.0 — one sign-in for every product of a church Phase **3** of [ROADMAP-v3.md](./ROADMAP-v3.md) (§3, §8, §9; decisions 2, 14, 15, 17). Written -2026-11-18. **Decisions confirmed 2026-11-18** (all as proposed). **Partly built 2026-11-18** on -`feat/accounts-1.0` (not merged): the app, contracts 1.5.0, `packages/auth-client`, `packages/ui` and -the deploy hooks. Not yet: Hub 2.3.0, `crosscode install`/`add` for Accounts, the Playwright run and -the VM test. See [Changes while building](#changes-while-building). +2026-11-18. **Decisions confirmed 2026-11-18** (all as proposed). **Built 2026-11-18** on branches (not +merged): `feat/accounts-1.0` here (the app, contracts 1.5.0, `packages/auth-client`, `packages/ui`, +`crosscode install`/`add`, agent 1.1.0), `feat/accounts-install` in events-hub (Hub 2.3.0), +`feat/one-sign-in` in crosscode-site. Not yet: the VM test and a real Postgres (on another device). See [Changes while building](#changes-while-building). **What Accounts is:** a small OpenID Connect provider per church, at `accounts.`. People sign in there once and are signed in to all of the church's products. Members never see it @@ -318,6 +318,19 @@ phone-first. logout; `LINKS_ALLOW_PRIVATE` (testing only) lets it reach 127.0.0.1. 6. **Accounts' part of a church export** is `accounts.json` (the church profile and people, no secrets) next to the other products' files. +8. **The interaction address is `/api/v2/interaction/`**, which sends the browser on to + `/signin?uid=…`: oidc-provider scopes its interaction cookie to that address's path, so it has to + be the API's path for the sign-in. Found by the Playwright run (with `/signin` a real browser + never sent the cookie and every sign-in "expired"); the API tests' browser now honours cookie + paths too. The address is absolute (`ACCOUNTS_URL`), and behind a proxy `TRUST_PROXY` must be on + (it is in production) so the provider's own addresses use the public host. +9. **Playwright runs without a database**: `e2e/server.ts` runs the real backend on the tests' + in-memory database with a test product on `@crosscode/auth-client`; 8 tests on the real pages. +10. **Installing** (§9): the Hub already gave a church its free Accounts licence with its first + product and never billed it (Hub 2.0). Hub 2.3.0 adds Accounts to New install: the first + product of a church (an `install` job), or next to its others on the same server (an + `add-product` job). `crosscode install` takes one product at a time (events or accounts); + `crosscode add ` adds the next. Agent 1.1.0 runs both. 7. **`/api/health` reads the version from package.json** (PM2 doesn't set npm's variables), so `crosscode deploy` can check it. diff --git a/docs/HANDOVER.md b/docs/HANDOVER.md index a339a41..5ac2b89 100644 --- a/docs/HANDOVER.md +++ b/docs/HANDOVER.md @@ -29,7 +29,7 @@ for each phase and the rollout checklist ([ROLLOUT-1.0.md](./ROLLOUT-1.0.md)). | 1c | Cross Events 2.3.x: authenticator app 2FA (TOTP + recovery codes) | **Released** 2026-11-17 (`events@2.3.0`). **`events@2.3.1`** 2026-11-18: Next.js 16.4.6 (security advisories for 16.2.0–16.4.4), so roll out 2.3.1, not 2.3.0. crosscode-site `v1.3.0` lists it (merged and tagged, **not deployed**) | | 1d | Agent 1.0.x + Hub 2.1.x (+ contracts 1.3.0) | **Released** 2026-11-17 (`agent@1.0.0`, `contracts@1.3.0`, Hub `v2.1.0`). **VM tested** end to end (AGENT-1.0-PLAN §13: joins, installs behind frp, scheduled / batch / missed updates, uninstall with export and purge, forged and replayed jobs). 2026-11-18: **`agent@1.0.1`** (the agent answers status on the central server itself) and Hub **`v2.1.1`** (adopt passes the church's address; Link takes the short name as a name). **Not rolled out**: use agent 1.0.1 and Hub 2.1.1 | | 2 | Cross Events 2.4.0: protocol v2, Linked products, event feed, `packages/seo` (+ contracts 1.4.0, Hub 2.2.0) | **Built** 2026-11-18 ([EVENTS-2.4-PLAN.md](./EVENTS-2.4-PLAN.md), decisions taken as proposed, "Changes while building" there): `feat/events-2.4` here, `feat/link-public-key` in events-hub, `feat/linked-products` in crosscode-site. Unit tests pass. **Not tagged:** the e2e spec and the VM test haven't run (no Postgres on the dev machine) | -| 3 | Accounts 1.0.0 (+ contracts 1.5.0, Hub 2.3.0) | **Partly built** 2026-11-18 on `feat/accounts-1.0` ([ACCOUNTS-1.0-PLAN.md](./ACCOUNTS-1.0-PLAN.md), decisions confirmed): the app (backend, pages, 37 tests), contracts 1.5.0, `packages/auth-client`, `packages/ui`, deploy hooks. **Still to do:** Hub 2.3.0 (Accounts licence with the first product, New install with Accounts), `crosscode install`/`add` for Accounts, a Playwright run of the pages, the VM test, crosscode-site | +| 3 | Accounts 1.0.0 (+ contracts 1.5.0, agent 1.1.0, Hub 2.3.0) | **Built** 2026-11-18 ([ACCOUNTS-1.0-PLAN.md](./ACCOUNTS-1.0-PLAN.md), decisions confirmed) on `feat/accounts-1.0` here, `feat/accounts-install` in events-hub, `feat/one-sign-in` in crosscode-site; not merged. 37 backend tests and 8 Playwright tests pass (no Postgres needed). **Still to do:** the VM test and a run on real Postgres (another device), then release | | 4–7 | Website 1.0.0 → Events 3.0.0 → App 1.0.0 → App 1.x | Not started | ## Next up